feat(dashboard): zero line when no data found #1480
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| export const FEATURE_FLAGS = { | |||
| enableSmartSourceDS: true, | |||
| }; | |||
There was a problem hiding this comment.
Suggested change
| }; | |
| } satisfies FeatureFlags; |
it does not makes sense now, but maybe they will add more strict types in future
|
|
||
| export const OverviewDashboard = ({ | ||
| dashboardDefinition, | ||
| }: { | ||
| dashboardDefinition: Record<string, unknown> | null; | ||
| }) => { | ||
| const dashboardCoreApi = useRef<DashboardCoreApi | null>(null); |
There was a problem hiding this comment.
I try to find out why it is needed. Is it not used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-76195
PR Type
What kind of change does this PR introduce?
Summary
Zero line is displayed when no data found for all dashboard charts, except those in resource tab.
Changes
For data charts where "No data found" message is displayed there is displayed chart with zero line, simulating none of the events to appear.
User experience
Please describe the user experience before and after this change. Screenshots are welcome for additional context.
Overview before changes:
Overview after changes:
Data Ingestion tab before changes:
Data Ingestion tab after changes:
Error tab before changes:
Error tab after changes:
Resource consumption tab after changes remains the same:
Checklist
If an item doesn't apply to your changes, leave it unchecked.